fix: Pin CI QA toolchain with mise#58
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mise.tomland commit the generatedmise.lockmise#v1.1.1so branch builds andmainuse the same pinnedgoandgolangci-lintprotocol/fetchtest lint violations and update contributor docs to match the new toolchain flowWhy
The failing main build was a real
golangci-lintfailure, and the repo was not actually pinning that tool throughmise.On top of that, the QA group in
.buildkite/pipeline.ymldepended onbase_image, which only exists onmain. Branch builds usedbase_image_check, so QA was not wired consistently across branches.This changes QA to install the pinned repo toolchain directly, which removes the branch/main split and makes the lint version explicit in-repo.
Impact
go,golangci-lint, andgo-cover-treemapmainmainlint breakage is fixed in the same changeValidation
mise run cimise run buildbk pipeline validate --file .buildkite/pipeline.yml