Handle ETIMEDOUT during socket connection #162
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #161 in which we failed to rescue
Errno::ETIMEDOUTerrors from our socket connection during test runs. This would cause the test run to complete with a non-zero exit code and cause build jobs to fail.This is the error that is now rescued:
I was able to reproduce the error by disabling my wifi mid run as reported in the issue. This PR fixes the bug under the same conditions.