Skip to content

Conversation

@blaknite
Copy link
Member

This fixes #161 in which we failed to rescue Errno::ETIMEDOUT errors from our socket connection during test runs. This would cause the test run to complete with a non-zero exit code and cause build jobs to fail.

This is the error that is now rescued:

bundler: failed to load command: rspec (.../ruby/2.7.0/bin/rspec)
Traceback (most recent call last):
	2: from .../ruby/2.7.0/gems/buildkite-test_collector-1.2.5/lib/buildkite/test_collector/socket_connection.rb:69:in `block in initialize'
	1: from .../lib/ruby/2.7.0/openssl/buffering.rb:125:in `readpartial'
.../lib/ruby/2.7.0/openssl/buffering.rb:125:in `sysread': Operation timed out (Errno::ETIMEDOUT)

I was able to reproduce the error by disabling my wifi mid run as reported in the issue. This PR fixes the bug under the same conditions.

@blaknite blaknite requested a review from a team as a code owner November 14, 2022 06:03
Copy link
Contributor

@niceking niceking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol I love that you disabled your wifi for this 😂

@blaknite blaknite merged commit 7d6a86e into main Nov 14, 2022
@blaknite blaknite deleted the pie-1286-fix-error-on-network-disconnect branch November 14, 2022 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Network connectivity during final report causing test process to exit with non-zero status

3 participants