Fix TestCommand cli flag binding#432
Merged
nprizal merged 1 commit intobuildkite:mainfrom Feb 1, 2026
Merged
Conversation
nprizal
approved these changes
Feb 1, 2026
Contributor
|
Thanks for the fix @jeremybumsted. |
gchan
approved these changes
Feb 1, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Saw that in
test-engine-client/cli.go
Line 122 in ed434c0
we were binding the env
BUILDKITE_TEST_ENGINE_TEST_CMDto the TestCommand config value for custom test runners, but this was removed in #431. Attempting to runbktecwith thecustomtest runner will result in an error despite setting that value.Context
test-engine-client/cli.go
Line 122 in ed434c0
Changes
Re-adds the binding
Testing
Manually tested running a custom test runner with the binary from v2.1.0-rc2 to verify, as well as with #431 to validate the config change.