Conversation
- Migrate Angular from v17 to v21 (step-by-step via ng update) - Update Storybook, @angular-eslint, ng-packagr, typescript accordingly - Move Angular packages to devDependencies in workspace package.json - Set peer dependencies to >=17.3.0 to avoid manual updates on future major releases
ng update changed indentation from 2 to 4 spaces in @component decorators. This restores the 2-space indent per .editorconfig and prettier config. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
These packages are not imported anywhere and don't exist in Storybook v10. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The project now uses pnpm, so the npm lockfile is no longer needed. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Per .editorconfig insert_final_newline = true. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
These layout components use simple selectors (column, stack, inline, etc.) without a prefix, which is intentional for this library. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
gabro
approved these changes
Mar 24, 2026
Member
gabro
left a comment
gabro
left a comment
There was a problem hiding this comment.
LGTM — fixed formatting, removed unused storybook packages, removed stale package-lock.json, added trailing newline, disabled selector prefix lint rule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ng update)@angular-eslint,ng-packagr,typescriptto compatible versionsdevDependenciesin workspacepackage.json>=17.3.0to avoid manual updates on future major releases