Replace example tag versions in README with placeholder values#377
Merged
Conversation
Since the current examples use `v5.0.0` which is old and leads to eg: #376 Ideally we'd have a `v5` branch/tag alias per #271, but in lieu of that I think it's best to use placeholder values rather than a version that's going to get stale over time. Signed-off-by: Ed Morley <501702+edmorley@users.noreply.github.com>
Collaborator
Author
|
@jkutner I don't suppose you have a moment to review? :-) |
edmorley
added a commit
that referenced
this pull request
Apr 2, 2026
Since the current examples use `v5.0.0` which is old and leads to eg: #376 Ideally we'd have a `v5` branch/tag alias per #271, but in lieu of that I think it's best to use placeholder values rather than a version that's going to get stale over time. Signed-off-by: Ed Morley <501702+edmorley@users.noreply.github.com>
Collaborator
Author
|
I ended up folding this into #412 because it's been 6 months waiting for a code review. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the current examples use
v5.0.0which is old and leads to eg: #376Ideally we'd have a
v5branch/tag alias per #271, but in lieu of that I think it's best to use placeholder values rather than a version that's going to get stale over time.