Add buildpacksio/pack:<version>-base images to delivery#1951
Merged
Conversation
| default: false | ||
|
|
||
| env: | ||
| BUILDER: "paketobuildpacks/builder-jammy-tiny" |
Member
Author
There was a problem hiding this comment.
No longer needed since we don't use the pack action to build pack.
| COPY . . | ||
| RUN make build | ||
|
|
||
| FROM scratch |
Member
Author
There was a problem hiding this comment.
We base the lifecycle image on gcr.io/distroless/static, so it might make sense here as well. It's not as small as scratch but it avoids the need for branching logic in the Dockerfile.
Signed-off-by: Natalie Arellano <narellano@vmware.com>
675dca1 to
074586f
Compare
Member
Author
|
Tested on fork, this appears to work fine: https://github.com/natalieparellano/pack/actions/runs/6670247077 |
Member
Author
|
Perhaps there's a better tagging schema vs |
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Member
Author
|
I imagine folks using a "base" image will want a floating tag for the latest version, so I added 01fbd91 |
jkutner
approved these changes
Oct 30, 2023
Signed-off-by: Joe Kutner <jpkutner@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I still need to test this out end-to-end but I think this should resolve #1554 by adding a pack image based on ubuntu:jammy to our delivery pipeline.
Output
Before
We publish:
After
We publish:
Documentation
Related
Resolves #1554