Skip to content

feat(cache): add ECR support for layer caching in buildkit#1329

Merged
argoyle merged 1 commit intomainfrom
feat/cache-ecr-support
Dec 4, 2025
Merged

feat(cache): add ECR support for layer caching in buildkit#1329
argoyle merged 1 commit intomainfrom
feat/cache-ecr-support

Conversation

@argoyle
Copy link
Copy Markdown
Member

@argoyle argoyle commented Dec 4, 2025

Introduce configuration options for AWS ECR as a remote layer cache
backend in buildkit builds. Update the documentation and code to
support caching layer configuration, improve build speed, and allow
for better management of build artifacts.

Comment thread pkg/config/config_test.go Outdated
Copy link
Copy Markdown
Member

@peter-svensson peter-svensson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't find a test for the case when someone tries to configure:

cache:
  gitlab:
    url: ...

Not something we support but how will the error message look like?

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 4, 2025

Codecov Report

❌ Patch coverage is 83.73984% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.65%. Comparing base (b1293c8) to head (1699d4b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/build/build.go 70.58% 14 Missing and 1 partial ⚠️
pkg/docker/auth.go 87.50% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1329      +/-   ##
==========================================
- Coverage   91.02%   90.65%   -0.38%     
==========================================
  Files          38       38              
  Lines        1683     1787     +104     
==========================================
+ Hits         1532     1620      +88     
- Misses         94      107      +13     
- Partials       57       60       +3     
Flag Coverage Δ
unittests 90.65% <83.73%> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Introduce configuration options for AWS ECR as a remote layer cache  
backend in buildkit builds. Update the documentation and code to  
support caching layer configuration, improve build speed, and allow  
for better management of build artifacts.
@argoyle argoyle force-pushed the feat/cache-ecr-support branch from 9a905e8 to 1699d4b Compare December 4, 2025 14:04
@argoyle
Copy link
Copy Markdown
Member Author

argoyle commented Dec 4, 2025

Didn't find a test for the case when someone tries to configure:

cache:
  gitlab:
    url: ...

Not something we support but how will the error message look like?

Like this:

yaml: unmarshal errors:
  line 19: field gitlab not found in type config.CacheConfig

@argoyle argoyle disabled auto-merge December 4, 2025 14:22
@argoyle argoyle merged commit 4078f52 into main Dec 4, 2025
9 of 11 checks passed
@argoyle argoyle deleted the feat/cache-ecr-support branch December 4, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants