fix: resolve configuration mismatch and implement loud migration warnings#1
Merged
Conversation
…ings This commit addresses several critical configuration path issues: 1. Environment Variable Fallback: codewhale_home() and legacy_deepseek_home() now explicitly check the $HOME environment variable before falling back to dirs::home_dir(). This fixes a bug on Windows where dirs::home_dir() could resolve to a different path than $HOME, causing split configuration states. 2. Robust Settings Migration: Added migrate_settings_if_needed() to safely migrate settings.toml from legacy DeepSeek folders (and Windows AppData) to the new CodeWhale configuration directory. 3. Loud Migration Exit: If any configuration or settings files are migrated on startup, the application now loudly notifies the user with colorful terminal output, displaying the exact paths to the new and legacy files, and safely exits to ensure the user verifies the new configuration before continuing.
buko
force-pushed
the
fix/config-mismatch-bug
branch
from
28e7765 to
62988d7
Compare
buko
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses several critical configuration path issues:
codewhale_home()andlegacy_deepseek_home()now explicitly check the$HOMEenvironment variable before falling back todirs::home_dir(). This fixes a bug on Windows wheredirs::home_dir()could resolve to a different path than$HOME, causing split configuration states.migrate_settings_if_needed()to safely migratesettings.tomlfrom legacy DeepSeek folders (and Windows AppData) to the new CodeWhale configuration directory.