fix: next checkbox bullet type#91
Merged
dkarter merged 1 commit intobullets-vim:masterfrom Mar 5, 2021
Merged
Conversation
Member
|
Thank you for the PR! LGTM! ✨ |
Member
|
@all-contributors please add @samgriesemer for code and bug |
Contributor
|
I've put up a pull request to add @samgriesemer! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what: This pull request allows for automatic insertion of checkbox bullet types
- [ ]and* [ ].why: From what I can tell, bullets.vim will match either
- [ ]or* [ ]syntax as checkbox bullets (seen in thematch_checkbox_bullet_item()function). However, when it comes to automatically inserting a new bullet in a list of checkboxes, thenext_chk_bullet()function only inserts new checkboxes with- [ ]syntax, regardless of the style matched in the list.how: The proposed change is a one line fix, inserting the first character of the matched checkbox bullet found in
match_checkbox_bullet_item()as the first character of the next bullet. This enables either of the matched syntax styles to be automatically extended (which seems like the expected behavior).testing: I've had this change made in my local vim setup for the last few days, and things seem to be working as expected. This is by no means comprehensive testing, but the nature of the fix leads me to believe the scope of possible consequences in quite small to begin with. Please let me know if there any issues or standards I've overlooked here.