Add InsideTheBackStack sample#302
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
detekt found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
zsoltk
reviewed
Dec 13, 2022
| import com.bumble.appyx.core.navigation.Operation | ||
| import com.bumble.appyx.core.state.SavedStateMap | ||
|
|
||
| class CustomBackStack<NavTarget : Any>( |
Contributor
There was a problem hiding this comment.
Can we simply use the standard BackStack instead?
Collaborator
Author
There was a problem hiding this comment.
we'll lose the animation if we use the regular BackStack
Contributor
|
We probably don't need to add the |
Collaborator
Author
I can remove the Logo |
zsoltk
approved these changes
Dec 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a new sample app to show how the back stack works, this was adapter from Challenge 2 from DroidCon London
It's the last item in the list:
Check list
CHANGELOG.mdif required.