fix(overlay): fix removal of elements of an array #693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the refactoring made on the overlay command in [v2.9.3](https://github.com/bump-sh/cli/releases/tag/v2.9.3) we introduced a bug when `remove`ing elements if the overlay action was targeting an array. This was due to the exploded json paths which contains indexes, and that those index change each time we remove an element. We've fixed the bug with @AurelDbs by iterating over the list of paths in a reversed order (we start by the end of the array instead of the beginning).
AurelDbs
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the refactoring made on the overlay command in
v2.9.3 we
introduced a bug when
removeing elements if the overlay action wastargeting an array.
This was due to the exploded json paths which contains indexes, and
that those index change each time we remove an element.
We've fixed the bug with @AurelDbs by iterating over the list of paths
in a reversed order (we start by the end of the array instead of the
beginning).
Note: once again, thanks @lcawl for reporting this issue! And sorry
for the unexpected behavior 🙂