Add standalone API source files + links in README #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulRbr
reviewed
May 23, 2023
Member
paulRbr
left a comment
paulRbr
left a comment
There was a problem hiding this comment.
Looks nice, thanks for this :). Could you add all the token variables needed for each documentation (similarly to this commit).
Note: we should really start to implement API tokens based on Users (instead of resource) at some point in the product! 🙂
paulRbr
reviewed
Jun 29, 2023
.github/workflows/deploy.yml
Outdated
Comment on lines
34
to
50
| ASI_BUMP_TOKEN: ${{ secrets.ASI_BUMP_TOKEN }} | ||
| AXONAUT_BUMP_TOKEN: ${{ secrets.AXONAUT_BUMP_TOKEN }} | ||
| FAIRJUNGLE_BUMP_TOKEN: ${{ secrets.FAIRJUNGLE_BUMP_TOKEN }} | ||
| GALISE_BUMP_TOKEN: ${{ secrets.GALISE_BUMP_TOKEN }} | ||
| GITGUARDIAN_BUMP_TOKEN: ${{ secrets.GITGUARDIAN_BUMP_TOKEN }} | ||
| HIBOUTIK_BUMP_TOKEN: ${{ secrets.HIBOUTIK_BUMP_TOKEN }} | ||
| INPI_API_RNCS_BUMP_TOKEN: ${{ secrets.INPI_API_RNCS_BUMP_TOKEN }} | ||
| LUMAPPS_BUMP_TOKEN: ${{ secrets.LUMAPPS_BUMP_TOKEN }} | ||
| MAPOTEMPO_BUMP_TOKEN: ${{ secrets.MAPOTEMPO_BUMP_TOKEN }} | ||
| NEXTAUTH_BUMP_TOKEN: ${{ secrets.NEXTAUTH_BUMP_TOKEN }} | ||
| PAPPERS_BUMP_TOKEN: ${{ secrets.PAPPERS_BUMP_TOKEN }} | ||
| PAYGREEN_BUMP_TOKEN: ${{ secrets.PAYGREEN_BUMP_TOKEN }} | ||
| REMOVE_BG_BUMP_TOKEN: ${{ secrets.REMOVE_BG_BUMP_TOKEN }} | ||
| RESTAURANTS_API_BUMP_TOKEN: ${{ secrets.RESTAURANTS_API_BUMP_TOKEN }} | ||
| SKALEET_BUMP_TOKEN: ${{ secrets.SKALEET_BUMP_TOKEN }} | ||
| SLACK_API_BUMP_TOKEN: ${{ secrets.SLACK_API_BUMP_TOKEN }} | ||
| TALEEZ_BUMP_TOKEN: ${{ secrets.TALEEZ_BUMP_TOKEN }} |
Member
There was a problem hiding this comment.
Nice thanks a lot for this! Did you add the secret variables on the repo settings taken from the token values of each APIs on Bump.sh?
Contributor
Author
There was a problem hiding this comment.
Yes they are all added using the right variable name formatting
paulRbr
approved these changes
Jun 29, 2023
Member
paulRbr
left a comment
paulRbr
left a comment
There was a problem hiding this comment.
I left a small questions about the Bump tokens, whether you have added some to the github settings or not? But LGTM, thanks alot!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing source files from the Bump demo org.
File name convention has been followed so the CI should not break