Skip to content

Update it.json #2210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
FlowerHurricane wants to merge 1 commit into from
Closed

Update it.json #2210

FlowerHurricane wants to merge 1 commit into from

Conversation

@FlowerHurricane
Copy link

@FlowerHurricane FlowerHurricane commented Apr 25, 2025

No description provided.

@TheophileDiot
Copy link
Member

TheophileDiot commented Apr 26, 2025

Hi @FlowerHurricane,
Thanks a lot for your contribution! 🙏 Could you please provide a bit more context around what was wrong and what motivated the changes to these keys?
It would really help us better understand the background and reasoning behind your update.
(Feel free to take inspiration from the approach wiseweb-works used in #2204 if that helps!)
Thanks again!

TheophileDiot
TheophileDiot requested changes Apr 26, 2025
View reviewed changes
Copy link
Member

@TheophileDiot TheophileDiot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • src/ui/app/static/locales/README.md needs to be modified to state that it has been checked by you.
  • We need more information about why the changes have been made.

@TheophileDiot TheophileDiot added the enhancement New feature or request label Apr 26, 2025
@TheophileDiot TheophileDiot linked an issue Apr 26, 2025 that may be closed by this pull request
[FEATURE] Adding foreign language support #274
Closed
@TheophileDiot TheophileDiot requested a review from Copilot April 30, 2025 16:03
Copilot AI reviewed Apr 30, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@TheophileDiot
Copy link
Member

TheophileDiot commented May 5, 2025

@FlowerHurricane bump

@TheophileDiot
Copy link
Member

TheophileDiot commented May 27, 2025

@FlowerHurricane bump ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@TheophileDiot TheophileDiot TheophileDiot requested changes

Assignees

@TheophileDiot TheophileDiot

@FlowerHurricane FlowerHurricane

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE] Adding foreign language support

2 participants

@FlowerHurricane @TheophileDiot