-
Notifications
You must be signed in to change notification settings - Fork 2
Immutable vnodes #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Immutable vnodes #33
Conversation
|
This is currently broken despite all tests passing. Yikes! |
|
Looks better now, though the fact that the tests didn't catch these issues is disconcerting! |
|
Tests are passing and some ff4s examples look ok, too. The biggest concern is probably performance, although the todo-mvc benchmark using ff4s barely budged after the change. Not sure what to make of that. |
This would be my concern, would be nice to add some tests for these. Unfortunately I don't think I can do an in-depth review of this one, but if it works it works :) 👍 |
No worries! I'm aware that this is a big change, and one that marks a clear departure from the original snabbdom. Any high level feedback would still be appreciated ;). Having immutable vnodes is one of the things mentioned by @cornerman in this issue. I'll try to increase test coverage to include the cases I came across when making these changes. |
…ts in long-running tests
Experiments in making vnodes immutable.