Closed
Conversation
Member
|
Thanks much. Would you be comfortable with the addition of a "Signed-off-by:" in the commit message? i.e. https://github.com/bup/bup/blob/master/SIGNED-OFF-BY |
Contributor
Author
|
Signed-off-by: JP MARMORAT jpmarmorat@gmail.com Sorry i'm not familiar with the pull-request protocol |
Contributor
Author
|
After
git commit --amend
git push --force
the new commit message in kokopopse/bup/lib is:
TypeError: can't concat str to bytes
Signed-off-by: Jean-Paul MARMORAT
jean-paul.marmorat@mines-paristech.fr
jpmarmorat@gmail.com
Correct ?
Thx.
…----- Le 22 Nov 20, à 20:04, Rob Browning <notifications@github.com> a écrit :
| Thanks much. Would you be comfortable with the addition of a "Signed-off-by:" in
| the commit message? i.e. [ https://github.com/bup/bup/blob/master/SIGNED-OFF-BY
| | https://github.com/bup/bup/blob/master/SIGNED-OFF-BY ]
| —
| You are receiving this because you authored the thread.
| Reply to this email directly, [
| #60 (comment) | view it on GitHub ]
| , or [
| https://github.com/notifications/unsubscribe-auth/ABGSXTSOXUVKWXJUQGL6WRDSRFODBANCNFSM4TMZJ6YA
| | unsubscribe ] .
--
__________________
Jean-Paul Marmorat
|
Member
|
Thanks. Would you be OK with just matching the commit "Author:", since we haven't really thought about how to handle multiple identifiers there yet, and it's generally been the author. |
Signed-off-by: Jean-Paul Marmorat jean-paul.marmorat@mines-paristech.fr index 7c8ca26..3797724 100755 --- a/lib/cmd/restore-cmd.py +++ b/lib/cmd/restore-cmd.py @@ -192,7 +192,7 @@ def restore(repo, parent_path, name, item, top, sparse, numeric_ids, owner_map, out.write(b'%s@ -> %s\n' % (fullname, meta.symlink_target)) else: if verbosity >= 2: - out.write(fullname + '\n') + out.write(fullname + b'\n') orig_cwd = os.getcwd() try: ~ ~ ~ ~ ~
Contributor
Author
|
Should be OK for now.
Sorry for the delay, I was new to the procedure.
Bup is great.
…----- Le 24 Nov 20, à 22:45, Rob Browning <notifications@github.com> a écrit :
| Thanks. Would you be OK with just
| Signed-off-by: Jean-Paul Marmorat <jean-paul.marmorat@mines-paristech.fr>
| matching the commit "Author:", since we haven't really thought about how to
| handle multiple identifiers there yet, and it's generally been the author.
| —
| You are receiving this because you authored the thread.
| Reply to this email directly, [
| #60 (comment) | view it on GitHub ]
| , or [
| https://github.com/notifications/unsubscribe-auth/ABGSXTV26TI3QI7K6G7Q7OTSRQSP7ANCNFSM4TMZJ6YA
| | unsubscribe ] .
--
__________________
Jean-Paul Marmorat
|
Member
|
Incorporated as a97b156. Thanks again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
index 7c8ca26..3797724 100755
--- a/lib/cmd/restore-cmd.py
+++ b/lib/cmd/restore-cmd.py
@@ -192,7 +192,7 @@ def restore(repo, parent_path, name, item, top, sparse, numeric_ids, owner_map,
out.write(b'%s@ -> %s\n' % (fullname, meta.symlink_target))
else:
if verbosity >= 2:
orig_cwd = os.getcwd()
try:
~
~
~
~
~
We discuss code changes on the mailing list bup-list@googlegroups.com,
but if you'd prefer to begin the process with a pull request, that's
just fine. We're happy to have the help.
In any case, please make sure each commit includes a
Signed-off-by: Someone someone@some.where
line in the commit message that matches the "Author" line so that
we'll be able to include your work in the project. See
./SIGNED-OFF-BY for the meaning:
https://github.com/bup/bup/blob/master/SIGNED-OFF-BY
After you submit the pull request, someone will eventually redirect it
to the list for review, and you will of course be included in the
conversation there.
On the other hand, if you're comfortable with "git send-email" (or the
equivalent), please post your patches to the list as described in the
"Submitting Patches" section in ./HACKING:
https://github.com/bup/bup/blob/master/HACKING