QDB-18722 - [python] - remove deprecated API code#118
Merged
Conversation
solatis
reviewed
Apr 14, 2026
Contributor
solatis
left a comment
solatis
left a comment
There was a problem hiding this comment.
Seems like you're adding backwards compatibility to tests that can be removed?
Comment on lines
+31
to
+58
| def _read_single_column(conn, table, column, *, ranges=None): | ||
| idx, xs = qdbnp.read_arrays( | ||
| conn, | ||
| [table], | ||
| column_names=[column], | ||
| ranges=ranges, | ||
| ) | ||
| return idx, xs[column] | ||
|
|
||
|
|
||
| def _write_single_column( | ||
| conn, table, column, data, index, *, dtype=None, infer_types=True, **kwargs | ||
| ): | ||
| payload = {column: data} | ||
| if dtype is not None: | ||
| dtype = {column: dtype} | ||
|
|
||
| return qdbnp.write_arrays( | ||
| payload, | ||
| conn, | ||
| table, | ||
| index=index, | ||
| dtype=dtype, | ||
| infer_types=infer_types, | ||
| **kwargs, | ||
| ) | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
Are these necessary, are you adding backawards compatibility for single column tests that were originally testing the old API?
Contributor
Author
There was a problem hiding this comment.
no, this wrappers need for tests that operate just with one column
we have a lot of them
Contributor
Author
There was a problem hiding this comment.
tests check different data conversions
Contributor
Author
There was a problem hiding this comment.
for example, test_arrays_deduplicate
Contributor
Author
There was a problem hiding this comment.
test_arrays_read_write_inferrable_dtypes
solatis
approved these changes
Apr 16, 2026
vikonix
added a commit
that referenced
this pull request
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.