build: update helm-chart workflow#360
Merged
burningalchemist merged 2 commits intoburningalchemist:masterfrom Oct 16, 2023
allanger:update-chart-again
Merged
build: update helm-chart workflow#360burningalchemist merged 2 commits intoburningalchemist:masterfrom allanger:update-chart-again
burningalchemist merged 2 commits intoburningalchemist:masterfrom
allanger:update-chart-again
Conversation
burningalchemist
changed the title
burningalchemist
approved these changes
Oct 16, 2023
Owner
burningalchemist
left a comment
burningalchemist
left a comment
There was a problem hiding this comment.
Looks good to me, let's try.
Contributor
Author
|
Looks like, it's still broken. I'll check what else it can be. Sorry, it's taking so long I guess I need to check not against the master, but the previous commit. Since you're using squashed commits, it should work fine |
Owner
|
@allanger No worries at all. I apologise I can't be proactive to contribute as I'm currently busy with some other stuff. Hope it's fine for you to take care of it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hope these rules will work as expected.
Now when a PR is created there must be a new action that is linting and testing the chart. It should detect changes, so if it doesn't I'll check what else is wrong.
If changes are detected and changes are passed, it should trigger the release only when merged to the master