build: update Makefile to support native Windows builds#471
Merged
burningalchemist merged 1 commit intomasterfrom Mar 22, 2024
Merged
build: update Makefile to support native Windows builds#471burningalchemist merged 1 commit intomasterfrom
burningalchemist merged 1 commit intomasterfrom
Conversation
burningalchemist
changed the title
burningalchemist
force-pushed
the
fix/win-makefile
branch
from
4f7a93e to
cafd72f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given that some commands in the Makefile are unix-specific, it becomes complicated to build sql_exporter on Windows without using WSL or similar subsystems (e.g. Cygwin).
This PR creates Windows overrides for crucial commands.