fix: use modern golang functions (go fix)#991
Merged
burningalchemist merged 1 commit intomasterfrom May 3, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and code modernizations across the codebase, focusing on simplifying code, improving type usage, and leveraging newer Go standard library features. The main areas affected are utility functions, type definitions, duplicate label checking logic, and goroutine management.
Code Modernization and Type Improvements:
interface{}withanyin theLogFunctype and its method to align with modern Go conventions, making the code more idiomatic.Logic Simplification and Use of Standard Library:
MetricConfig.validateKeyLabelsto useslices.Containsinstead of a manual loop, simplifying the logic and improving readability. [1] [2]Utility and Concurrency Enhancements:
Accept-Encodingheader to usestrings.SplitSeq(likely a custom or newer function) and fixed the iteration method for improved correctness and clarity indecorateWriter.Warmup.Runmethod by replacing manualsync.WaitGroupmanagement with the more concisecwg.Gopattern, reducing boilerplate and potential errors.