Add support for configuring VCD traces from the commandline. #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buserror
reviewed
May 1, 2018
simavr/sim/run_avr.c
Outdated
| uint16_t addr; | ||
| char name[64]; | ||
| } trace; | ||
| if(4 != sscanf(argv[pi], "%63[^=]=%63[^@]@0x%hx/0x%hhx", &trace.name[0], &trace.kind[0], &trace.addr, &trace.mask)) { |
Owner
There was a problem hiding this comment.
Please use if( -- also -- please don't use Yoda notation for conditions.
Contributor
Author
There was a problem hiding this comment.
Could you please clarify? By "Yoda notation" you probably mean to have if(sscanf(...) != 4), but I don't understand the first part, "please use if( -- also --"?
Owner
There was a problem hiding this comment.
sorry github ate my less-than greather-than tag... I mean please use if+space+parenthesis -- in general also use spaces in expressions like if (pe + 1 >= argc) { ... and yes Yoda notation is reversed if conditions... that was super handy trick in 1985 ;-)
Owner
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.