This repository was archived by the owner on Jun 5, 2020. It is now read-only.
fix last test failure in buster-dev-tools/runtests#15
Merged
cjohansen merged 3 commits intobusterjs:masterfrom Jan 3, 2013
Merged
fix last test failure in buster-dev-tools/runtests#15cjohansen merged 3 commits intobusterjs:masterfrom
cjohansen merged 3 commits intobusterjs:masterfrom
Conversation
… when it's just not there "catch any" is particularly annoying in case of errors *within* local.js
…n node 0.6 to 0.8.16 we were getting a buffer instead of a string. That's why assert.equals failed.
cjohansen
added a commit
that referenced
this pull request
Jan 3, 2013
fix last test failure in buster-dev-tools/runtests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were comparing a string with a buffer. That's due to an API change in fs.readFileSync, the key thing in its doc being
See also: thread on dev mailing list