This repository was archived by the owner on Sep 7, 2018. It is now read-only.
allow more than 3 arguments in handleUncaughtError()#423
Merged
Conversation
dkl-ppi
added a commit
that referenced
this pull request
Oct 1, 2014
allow more than 3 arguments in handleUncaughtError()
Member
|
Thank you! Good job! Keep going! ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is probably a recent change in the browsers - Firefox and Chrome now both have 5 arguments to
window.onerrorhttps://developer.mozilla.org/en-US/docs/Web/API/GlobalEventHandlers.onerror
This fixes
Uncaught exception: undefinedat the start of the test run into an actually readableUncaught exception: ./index.test.js:1 Uncaught ReferenceError: require is not defined(or whatever the error was)Part of #422