This repository has been archived by the owner. It is now read-only.

allow more than 3 arguments in handleUncaughtError() #423

Merged
merged 1 commit into from Oct 1, 2014

Conversation

Projects
None yet
2 participants
@dominykas
Member

dominykas commented Sep 22, 2014

This is probably a recent change in the browsers - Firefox and Chrome now both have 5 arguments to window.onerror

https://developer.mozilla.org/en-US/docs/Web/API/GlobalEventHandlers.onerror

This fixes Uncaught exception: undefined at the start of the test run into an actually readable Uncaught exception: ./index.test.js:1 Uncaught ReferenceError: require is not defined (or whatever the error was)

Part of #422

dwittner added a commit that referenced this pull request Oct 1, 2014

Merge pull request #423 from dymonaz/onerror-args-length
allow more than 3 arguments in handleUncaughtError()

@dwittner dwittner merged commit 600b5cb into busterjs:master Oct 1, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@dwittner

This comment has been minimized.

Member

dwittner commented Oct 1, 2014

Thank you! Good job! Keep going! ;)

@dominykas dominykas deleted the dominykas:onerror-args-length branch Oct 1, 2014

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.