Skip to content

Ty/dlc 4403#22

Merged
tylerjnap merged 5 commits intomasterfrom
ty/DLC-4403
Jul 19, 2017
Merged

Ty/dlc 4403#22
tylerjnap merged 5 commits intomasterfrom
ty/DLC-4403

Conversation

@tylerjnap
Copy link
Contributor

No description provided.

@tylerjnap tylerjnap requested a review from griffinmyers July 18, 2017 16:56
Copy link
Contributor

@griffinmyers griffinmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

index.js Outdated
customers: resources.customers(requestOptions, maybePromiseRequest),
merchants: resources.merchants(requestOptions, maybePromiseRequest),
orders: resources.orders(requestOptions, maybePromiseRequest)
orders: resources.orders(requestOptions, maybePromiseRequest),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this repo is currently formatted without trailing commas at the end of objects. It is Button style now, but let's keep it consistent here and upgrade all instances at once in a separate change if we want.

};

this.customer = {
id: 'customer-1234'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.customerId

@tylerjnap tylerjnap merged commit 40a5685 into master Jul 19, 2017
@tylerjnap tylerjnap deleted the ty/DLC-4403 branch July 19, 2017 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants