docker: switch to multistage build#22
Conversation
| github.com/18F/hmacauth 1.0.1 | ||
| gopkg.in/yaml.v2 v2 | ||
| github.com/imdario/mergo v0.3.4 | ||
| github.com/BurntSushi/toml d94612f9fc140360834f9742158c70b5c5b5535b |
There was a problem hiding this comment.
Thought we'd already removed this!
loganmeetsworld
left a comment
There was a problem hiding this comment.
Looks good @mccutchen!
|
Size difference, for posterity: Went from 1.13GB to 26.3MB! |
|
Check latest commit, we need to add the |
|
Another update: Apparently something about the alpine image prevents the pure Go DNS resolver from properly reading Now we've updated to |
|
wow, great size savings! |
|
Just one request: Can we squash the commits or rephrase the last two commits to give a little more context? |
|
Yep! Just wanted to makes sure y’all had a chance to see the individual
fixes before I squashed them away!
|
This results in a minimal final image without the full golang runtime. We settled on debian:stable-slim for the final base image because of issues with alpine and the Go native DNS resolver ignoring /etc/hosts, which can cause problems for some deployment approaches.
b6ade8a to
8f659e9
Compare
|
@loganmeetsworld squashed! |
This results in a minimal final image without the full golang runtime, addressing #20.
RFR @loganmeetsworld @shrayolacrayon
cc @danbf