Add off budget and on budget rule logic#185
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #185 +/- ##
=======================================
Coverage 97.94% 97.95%
=======================================
Files 21 21
Lines 3117 3128 +11
=======================================
+ Hits 3053 3064 +11
Misses 64 64 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
Nice, could you additionally link the relevant code snipped from this rule on the original source code? |
Contributor
Author
|
Added onBudget logic as well. |
Owner
|
Thank you for the contribution @JaxOfDiamonds , I did just a small refactor to simplify the import. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated logic so rules can handle the offBudget and onBudget account condition. The exact condition is used in the test case.
Motivation
offBudget and onBudget account rule was failing.
Server source code
Excerpt from line 403 of condition.ts: