Closed
Conversation
In certain situations, consumers benefit from being able to control how virtualized items are placed, such as when managing aria attributes (where the DOM hierarchy determines accessibility; see https://www.w3.org/TR/wai-aria-1.1/#grid). This commit adds some light tooling to allow consumers to specify exactly how children are placed in the DOM hierarchy.
Owner
|
This code change seems solid. I need to think on it more before I am willing to commit to merging it though. Getting rid of the range renderer prop felt like a nice change from react-virtualized to react-window. Re-adding it would add extra function calls to relatively hot code. |
Author
|
Closing -- no time to work on this, and the iron's no longer hot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In certain situations, consumers benefit from being able to control how virtualized items are placed, such as when managing aria attributes (where the DOM hierarchy determines accessibility; see
https://www.w3.org/TR/wai-aria-1.1/#grid).
In this pull request, one could fulfill the accessibility requirement with a
cellRangeRendererfunction, such as the example below:Should address #217