Closed
Conversation
Closed
gitlost
added a commit
to gitlost/postscriptbarcode
that referenced
this pull request
Oct 12, 2024
Latch/unlatch extended on 4 chars instead of 5 for better encodation in certain cases (and no pessimizations found so far), part addresses PR bwipp#272, props lyngklip Also fix masked extended chars matching ASCII digits in `numsscr` (skipped using re-synced `numEA` array)
gitlost
added a commit
to gitlost/postscriptbarcode
that referenced
this pull request
Oct 12, 2024
Adapted from ZXing (props Alex Geller) - maybe 80% slower depending on data & stack heavy but does improve some outcomes when FNC1s present (GS1 or manual) although not much else it appears (the previous algorithm was pretty good) Prompted by tests added from PR bwipp#272, props lyngklip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few test cases that I came up with while reviewing code128. Reading postscript is like listening to Yoda. Thank you for this interesting project.