Add support for short module names#108
Merged
bwplotka merged 4 commits intobwplotka:mainfrom Feb 28, 2022
Merged
Conversation
Contributor
Author
|
@bwplotka Probably it is time also to change what are the required checks for the PR. Perhaps we can make Go 1.14 and 1.15 optional now and require 1.16 and 1.17? |
Contributor
Author
|
@bwplotka ping? |
Contributor
Author
|
|
Owner
|
Hah, sorry - ping me on Slack / Twitter next time - I don't follow GH notifications |
bwplotka
approved these changes
Feb 28, 2022
Owner
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
Thanks!
and thanks for going through testing framework - it needs some overhaul - takes ages for tests to pass and to maintain this cumulative flow...
Contributor
Author
|
Thx! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current code assumes module names have 3 or more path segments (typically
github.com/org/module), but there are cases where custom module names may not follow that convention and be justdomain/module. This is a small fix to support those modules as well.