CSVS-57 CircleQueue was added #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
placccebo
requested changes
Oct 18, 2017
| } | ||
| } | ||
|
|
||
| protected def getClient(endpoint: String): ApacheCloudStackClient = { |
| val secondElement = "2" | ||
| val thirdElement = "3" | ||
|
|
||
| "moveElementToEnd" should "move the first element to end of the queue" in { |
Collaborator
There was a problem hiding this comment.
"moveElementToEnd" should "move the first element to the end of the queue"
| assert(expectedResult == queue.getElements) | ||
| } | ||
|
|
||
| "moveElementToEnd" should "not change queue if element for move is not first" in { |
Collaborator
There was a problem hiding this comment.
"moveElementToEnd" should "not change a queue if an element is not first"
placccebo
requested changes
Oct 19, 2017
|
|
||
| val cloudStackTaskCreator = new CloudStackTaskCreator(cloudStackTaskCreatorSettings) { | ||
| override val endpointQueue = new CircleQueue[String](cloudStackTaskCreatorSettings.endpoints.toList) | ||
| override val endpointQueue = getEndPointQueue(cloudStackTaskCreatorSettings.endpoints.toList) |
|
|
||
| def moveElementToEnd(element: T): Unit = synchronized { | ||
| val currentIndex = elements.indexOf(element) | ||
| if(currentIndex != -1) { |
Collaborator
There was a problem hiding this comment.
add a space between "if" and condition: if (currentIndex != -1) ....
| class WeightedQueue[T](private val elementList: List[T]) { | ||
| protected val r = new Random | ||
|
|
||
| private val lengthOfArray = elementList.length |
Collaborator
There was a problem hiding this comment.
why does the name contain "array"? is it a list or array?
| elements = elements.take(currentIndex) ++ elements.takeRight(lengthOfArray - currentIndex - 1) :+ element | ||
| } | ||
| } else { | ||
| throw new IllegalArgumentException(s"Element: $element is not included in the initialization list: $elementList") |
Collaborator
There was a problem hiding this comment.
Requested element doesn't exist: $element
|
|
||
| private val lengthOfArray = elementList.length | ||
| private val sumOfNumbers = getSumOfNumbers(0, lengthOfArray) | ||
| private val gradeScaleElements: RangeMap[Integer, Int] = TreeRangeMap.create() |
Collaborator
There was a problem hiding this comment.
elementIndexByPossibility
|
|
||
| private var elements = elementList | ||
|
|
||
| fillRangeMap(0, lengthOfArray, 0) |
| } | ||
| } | ||
|
|
||
| private def getSumOfNumbers(acc: Int, lenght: Int): Int = { |
Collaborator
There was a problem hiding this comment.
getSum() = N * (first + last) / 2
placccebo
requested changes
Oct 19, 2017
| private val lengthOfArray = elementList.length | ||
| private val sumOfNumbers = getSumOfNumbers(0, lengthOfArray) | ||
| private val gradeScaleElements: RangeMap[Integer, Int] = TreeRangeMap.create() | ||
| private val lengthOfList = elementList.length |
placccebo
approved these changes
Oct 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.