Skip to content

fix: prevent unnecessary log interception when logging is disabled #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bybatkhuu merged 1 commit into from
Jun 6, 2026
Merged

fix: prevent unnecessary log interception when logging is disabled #78

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions src/beans_logging/intercepters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,9 @@ def add_intercepter(config: LoggerConfigPM) -> None:
config (LoggerConfigPM, required): Main logger config model to use intercepter settings.
"""

if not config.intercept.enabled:
return

_intercept_handler = InterceptHandler()

# Intercepting all logs from standard (root logger) logging:
Expand All @@ -60,18 +63,17 @@ def add_intercepter(config: LoggerConfigPM) -> None:
_intercepted_modules = set()
_muted_modules = set()

if config.intercept.enabled:
for _module_name in list(logging.root.manager.loggerDict.keys()):
if config.intercept.only_base:
_module_name = _module_name.split(".")[0]

if (_module_name not in _intercepted_modules) and (
_module_name not in config.intercept.ignore_modules
):
_logger = logging.getLogger(_module_name)
_logger.handlers = [_intercept_handler]
_logger.propagate = False
_intercepted_modules.add(_module_name)
for _module_name in list(logging.root.manager.loggerDict.keys()):
if config.intercept.only_base:
_module_name = _module_name.split(".")[0]

if (_module_name not in _intercepted_modules) and (
_module_name not in config.intercept.ignore_modules
):
_logger = logging.getLogger(_module_name)
_logger.handlers = [_intercept_handler]
_logger.propagate = False
_intercepted_modules.add(_module_name)

for _include_module_name in config.intercept.include_modules:
_logger = logging.getLogger(_include_module_name)
Expand Down