Skip to content

Use consistent Keys for MemcachedEngine.php #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
byjg merged 2 commits into from
Aug 25, 2025
Merged

Use consistent Keys for MemcachedEngine.php #19

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbdc218
Use consistent Keys for MemcachedEngine.php
byjg Aug 25, 2025
ff6092b
Merge branch 'master' into 5.0
byjg Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Psr16/MemcachedEngine.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ public function __construct(?array $servers = null, $logger = null, ?array $opti
protected function fixKey(string $key): string
{
$key = $this->getKeyFromContainer($key);
$key = preg_replace('/[^A-Za-z0-9_\-]/', '-', $key);
return "cache-" . $key;
}
Comment on lines 52 to 57
Copy link

@korbit-ai korbit-ai bot Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undocumented Complex Regex Pattern category Readability

Tell me more
What is the issue?

The regex pattern '/[^A-Za-z0-9_\-]/' lacks clarity and documentation about its purpose.

Why this matters

Complex regex patterns without explanation make code maintenance difficult and increase cognitive load for developers trying to understand the key sanitization logic.

Suggested change ∙ Feature Preview
// Define regex pattern with explanation
protected function fixKey(string $key): string
{
    $key = $this->getKeyFromContainer($key);
    // Replace any character that is not alphanumeric, underscore, or hyphen with a hyphen
    $key = preg_replace('/[^A-Za-z0-9_\-]/', '-', $key);
    return "cache-" . $key;
}
Provide feedback to improve future suggestions

Nice Catch Incorrect Not in Scope Not in coding standard Other

💬 Looking for more details? Reply to this comment to chat with Korbit.


Expand Down