Fix the toArray function to start the array at the root node xml#8
Merged
byjg merged 3 commits intobyjg:masterfrom Jul 2, 2025
Merged
Fix the toArray function to start the array at the root node xml#8byjg merged 3 commits intobyjg:masterfrom
byjg merged 3 commits intobyjg:masterfrom
Conversation
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
 |
Inefficient DOM to SimpleXML Conversion ▹ view | ✅ Fix detected |
 |
Missing XML import validation ▹ view | |
 |
Missing callable validation in array transformation ▹ view | ✅ Fix detected |
Files scanned
| File Path | Reviewed |
|---|---|
| src/XmlNode.php | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
byjg
requested changes
Jul 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description by Korbit AI
What change is being made?
Fix the
toArrayfunction in theXmlNodeclass to ensure the generated array starts at the root node of the XML structure and update the corresponding test cases.Why are these changes being made?
Previously, the
toArraymethod did not correctly represent the hierarchy starting with the root node, which could lead to a misrepresentation of the XML data structure. This change ensures that the hierarchical context is preserved, resulting in more accurate and intuitive array transformations. Additional test cases have been added to verify the correct conversion of XML attributes and mixed content to an array format, reflecting real-world XML complexity more accurately.