fix: null ptr dereference in DescriptorData::string_to_client_encoding#2934
Closed
fix: null ptr dereference in DescriptorData::string_to_client_encoding#2934
Conversation
Guard against null in_str in DescriptorData::string_to_client_encoding. The crash occurred when GET_NAME(character) returned nullptr (corrupted or freed character still referenced in the follower list during combat via msdp::GroupReporter::append_char -> perform_violence). Adds regression test descriptor.encoding.cpp to catch this crash. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Previous commit corrupted Russian comments by writing the file in UTF-8 instead of KOI8-R (Edit tool bypassed the encoding conversion workflow). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Owner
|
Если пройтись по цепочке стека то видно, предположение не верно, упали бы гораздо раньше |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Защитная проверка на null в
string_to_client_encoding— устраняет краш, но не корневую причину. Детальный анализ причины и варианты полного исправления — в #2932.Добавлен регрессионный тест
DescriptorEncoding.StringToClientEncoding_NullInput_DoesNotCrash.