perf: skip affect_total in ProcessPunctualStyle (#3106)#3130
Merged
Conversation
ProcessPunctualStyle applies multiple affects via ImposeAffect in loops, each triggering an expensive affect_total recalculation. This is wasteful because: - If victim dies from the hit, raw_kill → reset_affects calls affect_total - If victim survives, battle_affect_update recalculates on next round Switch to ImposeAffectNoRecalc to skip redundant recalculations. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bylins
force-pushed
the
perf/punctual-no-recalc
branch
from
e8fc2f7 to
cd31952
Compare
This was referenced Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
ImposeAffect→ImposeAffectNoRecalcinProcessPunctualStyle(2 loops).affect_totalis redundant here because:raw_kill→reset_affects→affect_totalanywaybattle_affect_updaterecalculates next roundProfiler after CastAffect fix shows Backstab at 5.8ms (96%) — this should help.
Test plan
🤖 Generated with Claude Code