feat(model): refactor model initialize method #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Model() can accept single model
Codecov Report
@@ Coverage Diff @@
## master #92 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 4 4
Lines 203 224 +21
Branches 24 24
=====================================
+ Hits 203 224 +21
Continue to review full report at Codecov.
|
ArrayZoneYour
force-pushed
the
feat/Model
branch
from
b79844a to
12fce12
Compare
leecade
reviewed
Apr 10, 2019
|
|
||
| # Github | ||
| .github/ | ||
| .github/ |
Contributor
There was a problem hiding this comment.
May use files field in package.json, works as whitelist for npm pack
leecade
reviewed
Apr 10, 2019
| Object.entries(models).forEach(([name, model]) => { | ||
| if (!Global.State[name]) { | ||
| Global.State[name] = model.state | ||
| const isNextModelType = (input: any): input is NextModelType => { |
leecade
approved these changes
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Model() can accept single model