Skip to content

fix: aws s3 support instance role #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhoufeng1989 merged 1 commit into from
Dec 20, 2024
Merged

fix: aws s3 support instance role #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions cloud/common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,11 @@ func (option AWSOption) Check() error {
}
validKeyConfig := option.SecretID != "" && option.SecretKey != ""
validAssumeRoleConfig := option.AssumeRoleArn != "" && option.AssumeRegion != ""
if !validKeyConfig && !validAssumeRoleConfig {
return errors.New("must have valid key pairs config or assume role config")
validInstanceRoleConfig := option.AssumeRoleArn == "" && option.AssumeRegion == "" && option.SecretID == "" && option.SecretKey == ""
if validKeyConfig || validAssumeRoleConfig || validInstanceRoleConfig {
return nil
}
return nil
return errors.New("must have valid key pairs config or assume role config")
}

type CommonOption struct {
Expand Down