chore(compose): drop fixed container_name from postgres service#267
Merged
Conversation
The explicit `container_name: omadia-postgres` is redundant for service DNS: within the compose network the middleware already resolves `postgres` via the service name and the `networks.omadia.aliases: [postgres]` alias (+ hostname). A fixed container_name also collides when a second compose project runs on the same host. Drop it and correct the now-stale comment.
…tgres-container-name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the explicit
container_name: omadia-postgresfrom thepostgresservice indocker-compose.yaml(and corrects the now-stale comment).Why
The fixed
container_namewas not needed for the middleware to reach Postgres:postgres), and the service already declaresnetworks.omadia.aliases: [postgres]plushostname: postgres— so thepostgresDNS name resolves regardless of the compose project prefix.container_namealso collides when a second compose project (or a parallel stack) runs on the same host, since Docker container names must be globally unique.Net: less surprising, no behavioural change to service discovery.
Verification
docker compose -f docker-compose.yaml config -q✅ (validates clean)