Skip to content

chore(issue): current task view#15760

Merged
boojack merged 3 commits intobytebase:mainfrom
boojack:chore/current-task-view
Apr 9, 2025
Merged

chore(issue): current task view#15760
boojack merged 3 commits intobytebase:mainfrom
boojack:chore/current-task-view

Conversation

@boojack
Copy link
Copy Markdown
Member

@boojack boojack commented Apr 9, 2025

Close BYT-7145

image

Copilot AI review requested due to automatic review settings April 9, 2025 06:43
@boojack boojack requested a review from a team as a code owner April 9, 2025 06:43
@cla-bot cla-bot bot added the cla-signed label Apr 9, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 9 changed files in this pull request and generated no comments.

Files not reviewed (5)
  • frontend/src/locales/en-US.json: Language not supported
  • frontend/src/locales/es-ES.json: Language not supported
  • frontend/src/locales/ja-JP.json: Language not supported
  • frontend/src/locales/vi-VN.json: Language not supported
  • frontend/src/locales/zh-CN.json: Language not supported
Comments suppressed due to low confidence (2)

frontend/src/components/IssueV1/components/TaskListSection/TaskListSection.vue:139

  • The removal of the event emission for selecting the first task in the filtered list may lead to unintended behavior if there is no alternative mechanism to update the selected task. Please confirm that this change is intentional and that task selection updates are handled appropriately elsewhere.
    // Removed event emission for selecting a task when it is not in the filtered list

frontend/src/components/IssueV1/components/TaskListSection/TaskListSection.vue:122

  • [nitpick] Consider using Array.some to check for the presence of the selected task rather than mapping the entire array and then using includes; this can improve readability and efficiency for larger task lists.
return !filteredTaskList.value.map((task) => task.name).includes(selectedTask.value.name);

@boojack boojack enabled auto-merge (squash) April 9, 2025 06:48
@boojack boojack merged commit 599be99 into bytebase:main Apr 9, 2025
8 checks passed
@boojack boojack deleted the chore/current-task-view branch April 9, 2025 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants