fix: resolve workspace name before PATCH masking_rule#97
Merged
adela-bytebase merged 1 commit intomainfrom Apr 21, 2026
Merged
Conversation
The policy API uses the resource string as an exact-match filter, so "workspaces/-" does not resolve to the current workspace for policy endpoints (only GetWorkspace has dash-expansion). Without this, the PATCH silently creates an orphan policy with resource="workspaces/-" instead of updating the real workspace policy. Fetch the real workspace name via GET /workspaces/- first, then use it in the PATCH URL. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workspaces/-does not resolve to the current workspace for policy endpoints — only theGetWorkspaceRPC has dash-expansion logic (workspace_service.go:57)resource = 'workspaces/{real_id}'(migration 3.16/0001 backfills this)allowMissing=truesilently creates a duplicate orphan policy (resource = 'workspaces/-') instead of updating the real one — the UI never sees itFetch the real workspace name via
GET /v1/workspaces/-first, then use it in the masking_rule PATCH URL.Follow-up to #96. Companion docs PR: bytebase/bytebase.com#1080
Test plan
🤖 Generated with Claude Code