fix(oracle): keep stored unit declarations in split#135
Merged
Conversation
rebelice
force-pushed
the
codex/oracle-split-stored-unit
branch
from
de2827c to
33d472e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Oracle lexical splitting for top-level CREATE FUNCTION/PROCEDURE bodies with declaration sections and no SQL*Plus slash separator.\n\nThe previous state machine allowed top-level stored units to end at the first semicolon before bodyStarted=true. That was intended for declaration-like forms, but it also split valid functions at declaration statements such as variable declarations before BEGIN.\n\nThis keeps those stored units open until END; while preserving call-spec bodies such as Java procedure specs and trigger CALL bodies.\n\nTests: go test ./oracle/parser