feat(googlesql/parser-ddl-spanner): CHANGE STREAM / SEQUENCE / ROLE / LOCALITY GROUP / PROTO BUNDLE + role GRANT

[h3n4l]

Node: googlesql/parser-ddl-spanner

Spanner-specific object DDL that the legacy ANTLR GoogleSQLParser.g4 has no first-class rule for — it models CHANGE STREAM / ROLE / LOCALITY GROUP on the generic-entity hook (which can't express the two-word object type + clauses) and grant_statement/revoke_statement accept only string-literal grantees. The omni parser, whose authoritative oracle for Spanner DDL is the live Cloud Spanner emulator (oracle.md), parses each as a dedicated statement so bytebase's Spanner consumers (Diagnose / GetQuerySpan / SplitSQL) see a real tree instead of a false syntax error.

Forms implemented (all emulator-accept-verified)

Object	Forms	truth1
CHANGE STREAM	CREATE (FOR ALL / FOR table_and_column [,…] / OPTIONS), ALTER (SET FOR/DROP FOR ALL/SET OPTIONS), DROP	DDL-024/025/026
SEQUENCE	CREATE [IF NOT EXISTS] [OPTIONS], ALTER [IF EXISTS] SET OPTIONS, DROP [IF EXISTS]	DDL-027/028/029
ROLE	CREATE ROLE, DROP ROLE	DDL-032/033
role GRANT/REVOKE	… TO/FROM ROLE r [,…], GRANT/REVOKE ROLE r [,…] TO/FROM ROLE r [,…], comma-separated object lists ON TABLE t1, t2 TO ROLE r	DDL-034-037
LOCALITY GROUP	CREATE [OPTIONS], ALTER [SET OPTIONS] (optional), DROP	DDL-041/042/043
PROTO BUNDLE	CREATE ( type [,…] ), ALTER INSERT?/UPDATE?/DELETE? (fixed order)	DDL-046/047

Design

• New AST nodes in ast/parsenodes.go (+ tags in nodetags.go, regenerated walk_generated.go). The role surface reuses the shared GrantStmt/RevokeStmt via a new GranteeRole grantee kind + Roles/Paths fields, so one union parser serves both the legacy ZetaSQL string-grantee dialect AND the Spanner role dialect.
• New parsers: spanner_change_stream.go, spanner_sequence.go (sequence + locality group + proto bundle), spanner_schema_role.go (role + role-grant helpers).
• Dispatch wired in create_table.go / alter_table.go / drop.go (CHANGE/LOCALITY are bare identifiers matched by spelling; SEQUENCE/PROTO are keywords) and grant_revoke.go (role-grant disambiguation + comma-object head). analysis/classify.go now classifies the new nodes as DDL.

Proof — differential vs the live emulator (PROVE gate)

spanner_ddl_oracle_test.go runs 81 fixtures, both polarities (accept AND reject) through the emulator via the harness/googlesql-spanner oracle and asserts omni's verdict matches. Run:

SPANNER_EMULATOR_HOST=localhost:9010 go test -tags googlesql_oracle ./googlesql/parser/ -run TestSpannerDDLDifferential

go test ./googlesql/{parser,ast,analysis}/ green; go vet clean. Dialect-divergent forms (legacy ZetaSQL string-grantee GRANT, empty OPTIONS (), object-named-keyword, no-type-keyword role grant) are EXCLUDED from the Spanner differential (emulator non-authoritative for the BigQuery/union dialect) and covered by unit tests instead.

Owned divergences

• feat(pg): add completion scope context #112 closed — INTERLEAVE IN PARENT … ON DELETE made optional in create_table.go (defaults to NO ACTION per DDL-007); the original port over-rejected the documented default and the emulator-accepted INTERLEAVE IN PARENT p. A dangling ON DELETE still rejects.
• fix(cosmosdb): fix position tracking and reject semicolons #8 closed — inline column PRIMARY KEY already accepted by the union parser (matches emulator); guarded by a regression test.
• feat(oracle): add lexer-based splitter #128 flagged — column-level GRANT (GRANT SELECT(cols) … TO ROLE): valid GoogleSQL (DDL-034) but the emulator rejects with "does not yet support column level access controls" (an emulator limitation, non-authoritative); the union parser accepts per docs.
• flagged — the central "Spanner object DDL is first-class, not generic-entity / role grantees not in legacy" dialect divergence (oracle + grammar-source evidence in the ledger).

Review

Two-reviewer gate. The Codex lens caught 3 real bugs (all fixed + regression-tested): (1) legacy GRANT ROLE ON … misrouted to the role-grant path, (2) over-permissive non-ROLE target on a role grant, (3) over-rejected comma-separated object lists. Oracle-driven follow-ups while fixing: role names are single identifiers (CREATE ROLE rejects dotted; DROP ROLE accepts a path), a comma-object list requires both a type keyword and ROLE grantees, and PROTO BUNDLE lists allow a trailing comma (change-stream column lists do not). The Claude lens ran as an adversarial self-review across all angles.

Scope note

The node's declared writes-globs centered on the new spanner_*.go files + the AST. The CREATE/ALTER/DROP/GRANT dispatch actually lives in create_table.go/alter_table.go/drop.go/grant_revoke.go (not parser.go), and the query-type classifier in analysis/classify.go — those out-of-scope edits were the minimal wiring + cross-node correctness needed to make the new forms parse and classify; recorded in the worker summary.

🤖 Generated with Claude Code