Skip to content

chore(deps): update js-component-bindgen#337

Merged
vados-cosmonic merged 3 commits into
bytecodealliance:mainfrom
vados-cosmonic:chore(deps)=update-js-component-bindgen
May 18, 2026
Merged

chore(deps): update js-component-bindgen#337
vados-cosmonic merged 3 commits into
bytecodealliance:mainfrom
vados-cosmonic:chore(deps)=update-js-component-bindgen

Conversation

@vados-cosmonic
Copy link
Copy Markdown
Contributor

No description provided.

@tschneidereit
Copy link
Copy Markdown
Member

@vados-cosmonic there seems to be a lot more going on here than just an update of one dependency. Can you update the description to include which changes you made, so I know what to look for?

@vados-cosmonic
Copy link
Copy Markdown
Contributor Author

Hey @tschneidereit so the update of one dep triggered the other updates. Because a newer version of js-component-bindgen uses newer versions of ecosystem crates (and we can't use arbitrarily different versions) it prompts an update of the crates. Another thing that componentize-js uses is wirm, which also has a copy of the ecosystem crates -- so you can see where the updates come from.

That said, this isn't working yet -- there seems to be some generation problem I'm looking into, so it's not quite ready for review just yet -- but the intention here is definitely to update the single dep, it's just more involved than one would otherwise think. Two people from the community have already tried (and had a hard time).

@vados-cosmonic
Copy link
Copy Markdown
Contributor Author

Hey @tschneidereit OK this is ready for review now -- tests are green!

Given the current code, the only change that will be made is js-component-bindgen which is @ 1.19.0-rc.7 will change to 1.19.0 as soon as the release goes out, no more changes to the code in componentize-js should be necessary.

Copy link
Copy Markdown
Member

@tschneidereit tschneidereit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, with two changes: the inline comments addressed and the commit message being a bit more descriptive, and the update to 2024 edition documented (with the introduction of rustfmt.toml either reverted or explained.)

Comment thread crates/spidermonkey-embedding-splicer/src/splice.rs Outdated
Comment thread crates/spidermonkey-embedding-splicer/src/stub_wasi.rs
Comment thread rustfmt.toml Outdated
@vados-cosmonic vados-cosmonic force-pushed the chore(deps)=update-js-component-bindgen branch 5 times, most recently from a6bc8a5 to 6fdfc01 Compare May 18, 2026 15:20
@vados-cosmonic
Copy link
Copy Markdown
Contributor Author

vados-cosmonic commented May 18, 2026

Sadly, the CI timeout needed to be bumped @tschneidereit @andreiltd . Looks like Windows + Weval is the new lagging test, so note for the future I guess.

[EDIT] Also, don't merge this just yet! I will release js-component-bindgen 1.19.0 soon :)

@vados-cosmonic vados-cosmonic force-pushed the chore(deps)=update-js-component-bindgen branch from 6fdfc01 to 53a40cf Compare May 18, 2026 16:01
This updates wirm to 5.0.0 to re-enable the custom section deleting functionality
@vados-cosmonic vados-cosmonic force-pushed the chore(deps)=update-js-component-bindgen branch from 53a40cf to f1d07f9 Compare May 18, 2026 16:28
@vados-cosmonic
Copy link
Copy Markdown
Contributor Author

OK, this is finally ready to go -- found some more places where I could update imports and remove qualified uses that I missed. js-component-bindgen is updated to 1.19.0, so once tests are 🟢 again I'll merge.

@vados-cosmonic vados-cosmonic merged commit 26037ef into bytecodealliance:main May 18, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants