chore(deps): update js-component-bindgen#337
Conversation
ab506f6 to
2d06628
Compare
|
@vados-cosmonic there seems to be a lot more going on here than just an update of one dependency. Can you update the description to include which changes you made, so I know what to look for? |
|
Hey @tschneidereit so the update of one dep triggered the other updates. Because a newer version of That said, this isn't working yet -- there seems to be some generation problem I'm looking into, so it's not quite ready for review just yet -- but the intention here is definitely to update the single dep, it's just more involved than one would otherwise think. Two people from the community have already tried (and had a hard time). |
|
Hey @tschneidereit OK this is ready for review now -- tests are green! Given the current code, the only change that will be made is |
tschneidereit
left a comment
There was a problem hiding this comment.
Seems good, with two changes: the inline comments addressed and the commit message being a bit more descriptive, and the update to 2024 edition documented (with the introduction of rustfmt.toml either reverted or explained.)
a6bc8a5 to
6fdfc01
Compare
|
Sadly, the CI timeout needed to be bumped @tschneidereit @andreiltd . Looks like Windows + Weval is the new lagging test, so note for the future I guess. [EDIT] Also, don't merge this just yet! I will release |
6fdfc01 to
53a40cf
Compare
This updates wirm to 5.0.0 to re-enable the custom section deleting functionality
53a40cf to
f1d07f9
Compare
|
OK, this is finally ready to go -- found some more places where I could update imports and remove qualified uses that I missed. |
No description provided.