chore(build): Move WPT support build-time to runtime config#257
Merged
tschneidereit merged 4 commits intomainfrom Aug 4, 2025
Merged
chore(build): Move WPT support build-time to runtime config#257tschneidereit merged 4 commits intomainfrom
tschneidereit merged 4 commits intomainfrom
Conversation
Instead of requiring a CMake build config option to enable WPT support, with this change that's moved to the new `--wpt-mode` runtime flag. Signed-off-by: Till Schneidereit <till@tillschneidereit.net>
Now that WPT doesn't need special build config anymore, we can use one runtime build for all tests. Signed-off-by: Till Schneidereit <till@tillschneidereit.net>
tschneidereit
force-pushed
the
wpt-aint-so-special
branch
2 times, most recently
from
f114263 to
f44689a
Compare
This ensures that the check for whether wasmtime is ready can read out the address it is serving on. Before, it was possible for that part to be in a different chunk of output and hence missed. Signed-off-by: Till Schneidereit <till@tillschneidereit.net>
tschneidereit
force-pushed
the
wpt-aint-so-special
branch
from
f44689a to
9f52784
Compare
When running in parallel with other tests in CI, 20 seconds can be insufficient, apparently. Signed-off-by: Till Schneidereit <till@tillschneidereit.net>
andreiltd
reviewed
Aug 4, 2025
Member
andreiltd
left a comment
andreiltd
left a comment
There was a problem hiding this comment.
Should justfile be updated as well?
Member
Author
It is updated as part of the changes here. Do you mean something besides the changes I applied? |
Member
|
Oh that's right I missed that, sorry! |
andreiltd
approved these changes
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of requiring a CMake build config option to enable WPT support, with this change that's moved to the new
--wpt-moderuntime flag.Instead of requiring a CMake build config option to enable WPT support, with this change that's moved to the new--wpt-moderuntime flag.Also changes CI to only do one build of the runtime itself for all types of tests.