Merged
Conversation
The previous approach didn't work as I thought it would. I think/hope that this approach will create separate PRs for StarlingMonkey and debugger releases. One thing to note is that this (as the previous version) changes the StarlingMonkey releases to have a `starlingmonkey_` prefix. That seems like the right thing to me, but it does mean that the release artifact paths are changing. Signed-off-by: Till Schneidereit <till@tillschneidereit.net>
Member
Author
|
@andreiltd my apologies for the churn here! I hope that we're nearing the end of it, but I certainly do not have any guarantees. |
andreiltd
reviewed
Oct 17, 2025
andreiltd
approved these changes
Oct 17, 2025
Member
andreiltd
left a comment
andreiltd
left a comment
There was a problem hiding this comment.
No worries at all, thank you for looking into this!
This was referenced Oct 16, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous approach didn't work as I thought it would. I think/hope that this approach will create separate PRs for StarlingMonkey and debugger releases.
One thing to note is that this (as the previous version) changes the StarlingMonkey releases to have a
starlingmonkey_prefix. That seems like the right thing to me, but it does mean that the release artifact paths are changing.