Add support for files whose canonical paths use UNC prefixes. #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, files on network shares have a canonical path which starts with the UNC "\\?\" prefix. With these prefixes, the OS no longer handles "." paths and trailing slashes, so handle them manually. Fixes #2650.
sunfishcode
force-pushed
the
sunfishcode/unc-path
branch
from
fa34d93 to
8893496
Compare
sunfishcode
force-pushed
the
sunfishcode/unc-path
branch
5 times, most recently
from
54edf80 to
91d3d4b
Compare
Member
Author
|
Looking at the test failures, this needs some more work before it's ready. |
sunfishcode
force-pushed
the
sunfishcode/unc-path
branch
from
91d3d4b to
a77b2e4
Compare
sunfishcode
force-pushed
the
sunfishcode/unc-path
branch
from
a77b2e4 to
2e51b7f
Compare
Member
Author
|
Windows has some functions which perform canonicalization. I've now submitted retep998/winapi-rs#992 to add bindings to these in winapi, so we can experiment with using those instead of trying to do the canonicalization manually. |
Member
Author
|
Another option is to use windows-rs. That seems like the next thing to try here. |
sunfishcode
force-pushed
the
main
branch
3 times, most recently
from
fc0ebc2 to
dd73714
Compare
sunfishcode
force-pushed
the
main
branch
4 times, most recently
from
4a03710 to
6e53944
Compare
sunfishcode
added a commit
that referenced
this pull request
Jun 17, 2022
windows-sys has bindings for `PathCchCanonicalizeEx`, `PathCchCombineEx`, and `PathCchAppendEx`, which we may be able to use in #156.
sunfishcode
added a commit
that referenced
this pull request
Jun 21, 2022
windows-sys has bindings for `PathCchCanonicalizeEx`, `PathCchCombineEx`, and `PathCchAppendEx`, which we may be able to use in #156.
Member
Author
|
A better path forward for this issue is to change cap-std to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, files on network shares have a canonical path which starts
with the UNC "\?" prefix. With these prefixes, the OS no longer
handles "." paths and trailing slashes, so handle them manually.
Fixes #2650.