Skip to content

Conversation

@dicej
Copy link
Contributor

@dicej dicej commented Jan 15, 2025

This is a follow up to #190, which included some redundant wording.

Copy link
Collaborator

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, the original words give a stronger sense of "it's the tool injecting these imports." If other folks prefer the more concise wording, though, then I'm happy to go with it.

@dicej
Copy link
Contributor Author

dicej commented Jan 15, 2025

I think the current wording is grammatically incorrect (mea cupla). Specifically: "...which components built with componentize-py use by default by generating components which...". When you ignore the middle bits, it reads "...which components ... use by default by generating components which..."; but the components aren't generating components -- componentize-py is. So I think something needs to change, at least.

@itowlson
Copy link
Collaborator

How about:

This is because wasmtime-py does not yet support resources, and componentize-py by default causes components to use resources by importing most of the wasi:cli world.

Sentence structure is a bit fiddly though...!

This is because wasmtime-py does not yet support resources, and when you run componentize-py without --stub-wasi, it imports resources from the wasi:cli world. [or "it generates components which import resources..."?]

@dicej
Copy link
Contributor Author

dicej commented Jan 15, 2025

How about:

This is because wasmtime-py does not yet support resources, and componentize-py by default causes components to use resources by importing most of the wasi:cli world.

Sentence structure is a bit fiddly though...!

This is because wasmtime-py does not yet support resources, and when you run componentize-py without --stub-wasi, it imports resources from the wasi:cli world. [or "it generates components which import resources..."?]

Either one works for me. I do prefer "generates components which import resources" over "causes components to use resources". I'll push an update shortly.

This is a follow up to bytecodealliance#190, which included some redundant wording.

Signed-off-by: Joel Dice <joel.dice@fermyon.com>
@dicej
Copy link
Contributor Author

dicej commented Jan 15, 2025

How does this sound (per my latest push)?

This is because wasmtime-py does not yet support resources, and componentize-py by default generates components which use resources from the wasi:cli world.

Copy link
Collaborator

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience!

@itowlson itowlson merged commit af6c5e7 into bytecodealliance:main Jan 15, 2025
@dicej
Copy link
Contributor Author

dicej commented Jan 15, 2025

Thanks for the thoughtful review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants