-
Notifications
You must be signed in to change notification settings - Fork 72
remove redundant wording from python.md #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
itowlson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me, the original words give a stronger sense of "it's the tool injecting these imports." If other folks prefer the more concise wording, though, then I'm happy to go with it.
|
I think the current wording is grammatically incorrect (mea cupla). Specifically: "...which components built with |
|
How about:
Sentence structure is a bit fiddly though...!
|
Either one works for me. I do prefer "generates components which import resources" over "causes components to use resources". I'll push an update shortly. |
This is a follow up to bytecodealliance#190, which included some redundant wording. Signed-off-by: Joel Dice <joel.dice@fermyon.com>
|
How does this sound (per my latest push)?
|
itowlson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience!
|
Thanks for the thoughtful review! |
This is a follow up to #190, which included some redundant wording.