refactor handling of multiple WIT paths and/or worlds#213
Merged
dicej merged 1 commit intobytecodealliance:mainfrom Apr 15, 2026
Merged
Conversation
dicej
force-pushed
the
refactor-multiple-wit-paths-and-or-worlds
branch
2 times, most recently
from
482e8a3 to
d489a80
Compare
This primarily addresses an issue introduced in v0.22.0 such that targeting a specific WIT path and world via the CLI failed if a Python dependency with a `componentize-py.toml` file was found in the specified search path which also had its own WIT path. In that case, we'd return an error because we couldn't find the CLI-specified world in the `componentize-py.toml`-specified WIT path, without bothering to look in the CLI-specified path. We had a test for a similar scenario, but it wasn't covering this exact case. Addressing the issue required significant refactoring of how multiple WIT paths and/or worlds are juggled. Hopefully the result is a bit easier to follow, although it's still pretty hairy.
dicej
force-pushed
the
refactor-multiple-wit-paths-and-or-worlds
branch
from
d489a80 to
fef57a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This primarily addresses an issue introduced in v0.22.0 such that targeting a specific WIT path and world via the CLI failed if a Python dependency with a
componentize-py.tomlfile was found in the specified search path which also had its own WIT path. In that case, we'd return an error because we couldn't find the CLI-specified world in thecomponentize-py.toml-specified WIT path, without bothering to look in the CLI-specified path. We had a test for a similar scenario, but it wasn't covering this exact case.Addressing the issue required significant refactoring of how multiple WIT paths and/or worlds are juggled. Hopefully the result is a bit easier to follow, although it's still pretty hairy.