fix: add empty.s to fix compilation error#6
Merged
Conversation
dicej
approved these changes
Mar 5, 2026
Contributor
dicej
left a comment
There was a problem hiding this comment.
Thanks, @jamesstocktonj1!
@asteurer any concerns about this?
asteurer
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When attempting to run unit tests whilst importing the
go.bytecodealliance.org/pkg/wit/typespackage I get the following compilation error:wit-bindgen-gogot round this issue by including a blankempty.sassembly file within each of the directories which includes a Go file that uses the//go:wasmimportdirective. See here for example.This tricks the Go compile into thinking there is an assembly implementation of the function which has been declared, and so it no longer complains about the missing function body.
After adding the following changes, unit tests run successfully without build error.
See more