Attach gzipped dylib as part of publishing#201
Merged
jeffcharles merged 1 commit intomainfrom Jan 30, 2023
Merged
Conversation
saulecabrera
approved these changes
Jan 19, 2023
Collaborator
Author
|
I'm going to hold off on this until we get the Wizer story for the provider figured out |
jeffcharles
force-pushed
the
jc.publish-dylib
branch
from
516b176 to
257a7c1
Compare
saulecabrera
approved these changes
Jan 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds attaching
javy-quickjs_provider-${{ javy_version }}.wasm.gzand its sha to releases.This seems like a reasonable way to start publishing a dylib to use though it does tie Javy and
javy_quickjs_providerversions together.The name format is somewhat arbitrary and I'm okay with changing it if it makes sense. But I figured the
.wasmextension should be enough of a hint about what architecture it's targeting to not need to includewasm32-wasiin the name.