feat(p2-shim): add sandboxing configuration to WASIShim#1213
Merged
vados-cosmonic merged 4 commits intobytecodealliance:mainfrom Jan 27, 2026
Merged
feat(p2-shim): add sandboxing configuration to WASIShim#1213vados-cosmonic merged 4 commits intobytecodealliance:mainfrom
vados-cosmonic merged 4 commits intobytecodealliance:mainfrom
Conversation
Add support for configuring filesystem preopens, environment variables, command-line arguments, and network access through the WASIShim constructor.
andreiltd
force-pushed
the
p2-shim-sandbox
branch
from
1348ba1 to
6d688ff
Compare
andreiltd
changed the title
vados-cosmonic
approved these changes
Jan 26, 2026
Collaborator
vados-cosmonic
left a comment
vados-cosmonic
left a comment
There was a problem hiding this comment.
LGTM 🚀
Happy to merge as-is but left some recommendations that you can take or leave!
Member
Author
|
Thanks for feedback! Let me address the suggestions before we merge. |
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com> Signed-off-by: Tomasz Andrzejak <andreiltd@users.noreply.github.com>
andreiltd
force-pushed
the
p2-shim-sandbox
branch
from
571658c to
90b3073
Compare
Collaborator
|
Going to restart the tests as soon as they finish... doing whatever they're doing. Might be some CI slowness today. |
andreiltd
force-pushed
the
p2-shim-sandbox
branch
from
8a7b225 to
b356ed9
Compare
andreiltd
force-pushed
the
p2-shim-sandbox
branch
from
b356ed9 to
650270c
Compare
andreiltd
force-pushed
the
p2-shim-sandbox
branch
from
650270c to
ba3f304
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
bytecodealliance:main
with commit Jan 27, 2026
a14e3e6
68 of 69 checks passed
Collaborator
|
🎉 The code in this PR was made available in the following release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for configuring filesystem preopens, environment variables, command-line arguments, and network access through the WASIShim constructor.
Closes: #466